flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6522) Add ZooKeeper cleanup logic to ZooKeeperHaServices
Date Sat, 01 Jul 2017 16:45:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071315#comment-16071315
] 

ASF GitHub Bot commented on FLINK-6522:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4204#discussion_r125164898
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/zookeeper/ZooKeeperHaServices.java
---
    @@ -113,6 +117,7 @@ public ZooKeeperHaServices(
     		this.runningJobsRegistry = new ZooKeeperRunningJobsRegistry(client, configuration);
     
     		this.blobStoreService = checkNotNull(blobStoreService);
    +		this.stateStorage = null;
    --- End diff --
    
    let's eagerly initialize this field


> Add ZooKeeper cleanup logic to ZooKeeperHaServices
> --------------------------------------------------
>
>                 Key: FLINK-6522
>                 URL: https://issues.apache.org/jira/browse/FLINK-6522
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Fang Yong
>
> The {{ZooKeeperHaServices}} provide a {{CuratorFramework}} client to access ZooKeeper
data. Consequently, all data (also for different job) are stored under the same root node.
When {{HighAvailabilityServices#closeAndCleanupAllData}} is called, then this data should
be cleaned up. This cleanup logic is currently missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message