flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
Date Sun, 30 Jul 2017 07:33:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106355#comment-16106355
] 

ASF GitHub Bot commented on FLINK-6493:
---------------------------------------

Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4328#discussion_r130235370
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
    @@ -175,14 +175,21 @@ public boolean equals(Object obj) {
     				return false;
     			}
     
    +			Snapshot snapshot;
    +
    +			if (obj instanceof Snapshot) {
    +				snapshot = (Snapshot)obj;
    +			} else {
    --- End diff --
    
    nit: if you place the condition for else first, declaration and assignment to snapshot
can be done in one line.


> Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
> -------------------------------------------------------------------------
>
>                 Key: FLINK-6493
>                 URL: https://issues.apache.org/jira/browse/FLINK-6493
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Ted Yu
>            Assignee: mingleizhang
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> {code}
>         && ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer()
== null)
>           || partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
>         && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot)
obj).getPartitionStateSerializerConfigSnapshot() == null)
>           || partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
> {code}
> The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot
is in combination with another clause.
> This may lead to NPE in the partitionStateSerializer.equals() call.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message