flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13
Date Tue, 25 Jul 2017 08:32:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099709#comment-16099709
] 

ASF GitHub Bot commented on FLINK-6429:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4373#discussion_r129237531
  
    --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
---
    @@ -1869,13 +1869,23 @@ private RexNode convertOver(Blackboard bb, SqlNode node) {
     			// Walk over the tree and apply 'over' to all agg functions. This is
     			// necessary because the returned expression is not necessarily a call
     			// to an agg function. For example, AVG(x) becomes SUM(x) / COUNT(x).
    +
    --- End diff --
    
    I think we can remove this file for now and rely on Calcite 1.13 implementation. We don't
need it anymore.


> Bump up Calcite version to 1.13
> -------------------------------
>
>                 Key: FLINK-6429
>                 URL: https://issues.apache.org/jira/browse/FLINK-6429
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Haohui Mai
>
> This is an umbrella issue for all tasks that need to be done once Apache Calcite 1.13
is released.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message