flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6422) Unreachable code in FileInputFormat#createInputSplits
Date Wed, 05 Jul 2017 09:47:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074504#comment-16074504
] 

ASF GitHub Bot commented on FLINK-6422:
---------------------------------------

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/4202
  
    Thanks @tzulitai for review! And thanks @tedyu for reporting this! 


> Unreachable code in FileInputFormat#createInputSplits
> -----------------------------------------------------
>
>                 Key: FLINK-6422
>                 URL: https://issues.apache.org/jira/browse/FLINK-6422
>             Project: Flink
>          Issue Type: Bug
>          Components: Batch Connectors and Input/Output Formats
>            Reporter: Ted Yu
>            Assignee: mingleizhang
>            Priority: Minor
>
> Here is related code:
> {code}
>     if (minNumSplits < 1) {
>       throw new IllegalArgumentException("Number of input splits has to be at least 1.");
>     }
> ...
>     final long maxSplitSize = (minNumSplits < 1) ? Long.MAX_VALUE : (totalLength /
minNumSplits +
>           (totalLength % minNumSplits == 0 ? 0 : 1));
> {code}
> minNumSplits wouldn't be less than 1 getting to the assignment of maxSplitSize.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message