flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6357) ParameterTool get unrequested parameters
Date Mon, 10 Jul 2017 12:02:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080226#comment-16080226
] 

ASF GitHub Bot commented on FLINK-6357:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4169#discussion_r126401183
  
    --- Diff: flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
    @@ -34,8 +36,7 @@
     
     	@Test(expected = RuntimeException.class)
     	public void testIllegalArgs() {
    -		ParameterTool parameter = ParameterTool.fromArgs(new String[]{"berlin"});
    -		Assert.assertEquals(0, parameter.getNumberOfParameters());
    --- End diff --
    
    oh, totally overlooked that


> ParameterTool get unrequested parameters
> ----------------------------------------
>
>                 Key: FLINK-6357
>                 URL: https://issues.apache.org/jira/browse/FLINK-6357
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The Gelly examples use {{ParameterTool}} to parse required and optional parameters. In
the latter case we should detect if a user mistypes a parameter name. I would like to add
a {{Set<String> getUnrequestedParameters()}} method returning parameter names not requested
by {{has}} or any of the {{get}} methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message