flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4431: [FLINK-7318] [futures] Replace Flink's futures in ...
Date Mon, 31 Jul 2017 16:11:24 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/BackPressureStatsTracker.java
    @@ -177,7 +177,7 @@ public boolean triggerStackTraceSample(ExecutionJobVertex vertex)
     						LOG.debug("Triggering stack trace sample for tasks: " + Arrays.toString(vertex.getTaskVertices()));
    -					Future<StackTraceSample> sample = coordinator.triggerStackTraceSample(
    +					CompletableFuture<StackTraceSample> sample = coordinator.triggerStackTraceSample(
    --- End diff --
    Why not you not returning a plain `Future` here? Shouldn't we only explicitly return a
`CompletableFuture` if we expect the caller to complete it?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message