flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4415: [FLINK-7269] Refactor passing of dynamic propertie...
Date Mon, 31 Jul 2017 09:57:33 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4415#discussion_r130312761
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
    @@ -79,7 +79,15 @@ public Configuration(Configuration other) {
     	}
     	
     	// --------------------------------------------------------------------------------------------
    -	
    +
    +	/**
    +	 * Set the process-wide dynamic properties to be merged with the configuration.
    +	 * @param dynamicProperties The given dynamic properties
    +     */
    +	public void setDynamicProperties(Configuration dynamicProperties) {
    +		this.addAll(dynamicProperties);
    +	}
    --- End diff --
    
    Why not using directly `addAll`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message