flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...
Date Fri, 28 Jul 2017 16:14:46 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r130074361
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala
---
    @@ -0,0 +1,111 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.dataview
    +
    +import org.apache.flink.annotation.Internal
    +import org.apache.flink.api.common.typeutils._
    +import org.apache.flink.api.common.typeutils.base.{CollectionSerializerConfigSnapshot,
ListSerializer}
    +import org.apache.flink.core.memory.{DataInputView, DataOutputView}
    +import org.apache.flink.table.api.dataview.ListView
    +
    +/**
    +  * A serializer for [[HeapListView]]. The serializer relies on an element
    +  * serializer for the serialization of the list's elements.
    +  *
    +  * <p>The serialization format for the list is as follows: four bytes for the
length of the lost,
    +  * followed by the serialized representation of each element.
    +  *
    +  * @param listSerializer List serializer.
    +  * @tparam T The type of element in the list.
    +  */
    +@Internal
    +class ListViewSerializer[T](listSerializer: ListSerializer[T])
    +  extends TypeSerializer[ListView[T]] {
    +
    +  override def isImmutableType: Boolean = listSerializer.isImmutableType
    +
    +  override def duplicate(): TypeSerializer[ListView[T]] = {
    +    new ListViewSerializer[T](listSerializer.duplicate().asInstanceOf[ListSerializer[T]])
    +  }
    +
    +  override def createInstance(): ListView[T] = new HeapListView[T](listSerializer.createInstance())
    +
    +  override def copy(from: ListView[T]): ListView[T] = {
    +    val list = from.asInstanceOf[HeapListView[T]].list
    +    new HeapListView[T](listSerializer.copy(list))
    +  }
    +
    +  override def copy(from: ListView[T], reuse: ListView[T]): ListView[T] = copy(from)
    +
    +  override def getLength: Int = -1
    +
    +  override def serialize(record: ListView[T], target: DataOutputView): Unit = {
    +    val list = record.asInstanceOf[HeapListView[T]].list
    +    listSerializer.serialize(list, target)
    +  }
    +
    +  override def deserialize(source: DataInputView): ListView[T] =
    +    new HeapListView[T](listSerializer.deserialize(source))
    +
    +  override def deserialize(reuse: ListView[T], source: DataInputView): ListView[T] =
    +    deserialize(source)
    +
    +  override def copy(source: DataInputView, target: DataOutputView): Unit =
    +    listSerializer.copy(source, target)
    +
    +  override def canEqual(obj: scala.Any): Boolean = obj != null && obj.getClass
== getClass
    +
    +  override def hashCode(): Int = listSerializer.hashCode()
    +
    +  override def equals(obj: Any): Boolean = canEqual(this) &&
    +    listSerializer.equals(obj.asInstanceOf[ListSerializer[_]])
    +
    +  override def snapshotConfiguration(): TypeSerializerConfigSnapshot =
    +    listSerializer.snapshotConfiguration()
    +
    +  // copy and modified from ListSerializer.ensureCompatibility
    +  override def ensureCompatibility(configSnapshot: TypeSerializerConfigSnapshot)
    --- End diff --
    
    Can this method be easier implemented by calling `listSerializer.ensureCompatibility`
and checking if the returned `CompatibilityResult` requires migration. If the passed serializer
is not `null` it is wrapped in a `ListViewSerializer`.
    
    This won't work for `MapViewSerializer` because it has to handle two serializers, but
for `ListViewSerializer` it should work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message