flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #4413: [BACKPORT-1.3][FLINK-7268] [checkpoints] Scope Sha...
Date Fri, 28 Jul 2017 13:08:39 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4413#discussion_r130075732
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandleTest.java
---
    @@ -186,6 +187,77 @@ public void testSharedStateDeRegistration() throws Exception {
     		verify(stateHandle2.getMetaStateHandle(), times(1)).discardState();
     	}
     
    +	/**
    +	 * This tests that re-registration of shared state with another registry works as expected.
This simulates a
    +	 * recovery from a checkpoint, when the checkpoint coordinator creates a new shared
state registry and re-registers
    +	 * all live checkpoint states.
    +	 */
    +	@Test
    +	public void testSharedStateReRegistration() throws Exception {
    +
    +		SharedStateRegistry stateRegistryA = spy(new SharedStateRegistry());
    +
    +		// Create two state handles with overlapping shared state
    --- End diff --
    
    Comment is leftover from other test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message