flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4280: [FLINK-7125] [yarn] Remove Configuration loading f...
Date Thu, 27 Jul 2017 15:13:50 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4280#discussion_r129870736
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
    @@ -62,25 +62,27 @@
     	 * Retrieves a client for a running cluster.
     	 * @param commandLine The command-line parameters from the CliFrontend
     	 * @param config The Flink config
    +	 * @param configurationDirectory Direcotry for configuration files
     	 * @return Client if a cluster could be retrieved
     	 * @throws UnsupportedOperationException if the operation is not supported
     	 */
     	ClusterType retrieveCluster(
    -			CommandLine commandLine,
    -			Configuration config) throws UnsupportedOperationException;
    +		CommandLine commandLine,
    +		Configuration config,
    +		String configurationDirectory) throws UnsupportedOperationException;
     
     	/**
     	 * Creates the client for the cluster.
     	 * @param applicationName The application name to use
     	 * @param commandLine The command-line options parsed by the CliFrontend
     	 * @param config The Flink config to use
    -	 * @param userJarFiles User jar files to include in the classpath of the cluster.
    -	 * @return The client to communicate with the cluster which the CustomCommandLine brought
up.
    +	 * @param configurationDirectory
    +	 *@param userJarFiles User jar files to include in the classpath of the cluster.  @return
The client to communicate with the cluster which the CustomCommandLine brought up.
     	 * @throws Exception if the cluster could not be created
     	 */
     	ClusterType createCluster(
    -			String applicationName,
    -			CommandLine commandLine,
    -			Configuration config,
    -			List<URL> userJarFiles) throws Exception;
    +		String applicationName,
    +		CommandLine commandLine,
    +		Configuration config,
    +		String configurationDirectory, List<URL> userJarFiles) throws Exception;
    --- End diff --
    
    Good catch. Will change it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message