flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4280: [FLINK-7125] [yarn] Remove Configuration loading f...
Date Thu, 27 Jul 2017 08:18:01 GMT
Github user pnowojski commented on a diff in the pull request:

    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
    @@ -722,12 +697,30 @@ public ApplicationReport startAppMaster(JobGraph jobGraph, YarnClient
     		// Setup jar for ApplicationMaster
     		LocalResource appMasterJar = Records.newRecord(LocalResource.class);
    -		LocalResource flinkConf = Records.newRecord(LocalResource.class);
    --- End diff --
    nit: for me it would be easier to understand/review the changes done here, if there was
a separate PR for changing formatting (splitting one param per line)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message