flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4273: [FLINK-7065] Separate the flink-streaming-java mod...
Date Wed, 26 Jul 2017 15:31:19 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4273#discussion_r129598422
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/RemoteExecutor.java ---
    @@ -106,8 +113,14 @@ public RemoteExecutor(InetSocketAddress inet, Configuration clientConfiguration,
     			List<URL> jarFiles, List<URL> globalClasspaths) {
     		this.clientConfiguration = clientConfiguration;
     		this.jarFiles = jarFiles;
    +		for (URL jarFileUrl : jarFiles) {
    +			try {
    +				JobWithJars.checkJarFile(jarFileUrl);
    +			} catch (IOException e) {
    +				throw new RuntimeException("Problem with jar file " + jarFileUrl, e);
    --- End diff --
    
    Can we make this a checked exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message