flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4271: [FLINK-7113] Make ClusterDescriptor independent of...
Date Wed, 26 Jul 2017 09:41:38 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4271#discussion_r129526492
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
---
    @@ -0,0 +1,81 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client.deployment;
    +
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.JobManagerOptions;
    +import org.apache.flink.configuration.TaskManagerOptions;
    +
    +/**
    + * Description of the cluster to start by the {@link ClusterDescriptor}.
    + */
    +public class ClusterSpecification {
    +	private final int masterMemoryMB;
    +	private final int taskManagerMemoryMB;
    +	private final int numberTaskManagers;
    +	private final int slotsPerTaskManager;
    +
    +	public ClusterSpecification(int masterMemoryMB, int taskManagerMemoryMB, int numberTaskManagers,
int slotsPerTaskManager) {
    +		this.masterMemoryMB = masterMemoryMB;
    +		this.taskManagerMemoryMB = taskManagerMemoryMB;
    +		this.numberTaskManagers = numberTaskManagers;
    +		this.slotsPerTaskManager = slotsPerTaskManager;
    +	}
    +
    +	public int getMasterMemoryMB() {
    +		return masterMemoryMB;
    +	}
    +
    +	public int getTaskManagerMemoryMB() {
    +		return taskManagerMemoryMB;
    +	}
    +
    +	public int getNumberTaskManagers() {
    +		return numberTaskManagers;
    +	}
    +
    +	public int getSlotsPerTaskManager() {
    +		return slotsPerTaskManager;
    +	}
    +
    +	@Override
    +	public String toString() {
    +		return "ClusterSpecification{" +
    +			"masterMemoryMB=" + masterMemoryMB +
    +			", taskManagerMemoryMB=" + taskManagerMemoryMB +
    +			", numberTaskManagers=" + numberTaskManagers +
    +			", slotsPerTaskManager=" + slotsPerTaskManager +
    +			'}';
    +	}
    +
    +	public static ClusterSpecification fromConfiguration(Configuration configuration) {
    +		int slots = configuration.getInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, 1);
    +
    +		int jobManagerMemoryMb = configuration.getInteger(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY);
    +		int taskManagerMemoryMb = configuration.getInteger(TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY);
    +
    +
    --- End diff --
    
    Good catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message