flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #4370: [FLINK-7231] [distr. coordination] Fix slot releas...
Date Thu, 20 Jul 2017 13:32:53 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
    @@ -661,10 +682,117 @@ public void testConcurrentGlobalFailAndRestarts() throws Exception
    +	@Test
    +	public void testRestartWithEagerSchedulingAndSlotSharing() throws Exception {
    --- End diff --
    Exactly, it extends test coverage to possible related conditions.
    I realized that we had no test about the "happy path" of eager scheduling and slot sharing
as well.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message