flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink issue #4239: [FLINK-6988] flink-connector-kafka-0.11 with exactly-once...
Date Wed, 19 Jul 2017 07:21:20 GMT
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4239
  
    One other comment regarding the commits:
    I would argue that df6d5e0 to 5ff8106 should not appear in the commit log history, since
in the end we actually have a completely new producer for 011 anyways.
    Also, 321a142 to 2cf5f3b should be squashed to a single commit for the addition of an
"exactly-once producer for 011" (the new `FlinkKafkaProducer` implementation and exactly-once
tests shouldn't stand alone as independent commits, IMO. `FlinkKafkaProducer` isn't used by
other producer version, and the exactly-once producer addition wouldn't be valid without the
tests).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message