flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4254: [FLINK-7067] [jobmanager] Fix side effects after failed c...
Date Mon, 17 Jul 2017 19:25:33 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4254
  
    I think this is a meaningful fix.
    
    I would suggest to do the tests different, though. The tests of the CheckpointCoordinator
overdo the mockito stuff so heavily that it becomes an extremely hard job to change anything
in the CheckpointCoordinator. Mocks are super maintenance heavy, compared to actual test implementations
of interfaces or classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message