flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink pull request #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorith...
Date Fri, 14 Jul 2017 19:32:18 GMT
Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4345#discussion_r127532604
  
    --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateGraphIds.java
---
    @@ -56,7 +56,9 @@ public TranslateGraphIds(TranslateFunction<OLD, NEW> translator)
{
     
     	@Override
     	protected boolean canMergeConfigurationWith(GraphAlgorithmWrappingBase other) {
    -		super.mergeConfiguration(other);
    +		if (!super.canMergeConfigurationWith(other)) {
    --- End diff --
    
    It can use the default implementation from `GraphAlgorithmWrappingBase`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message