flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io
Date Fri, 14 Jul 2017 17:23:34 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4340#discussion_r127505784
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/TextOutputFormat.java
---
    @@ -18,65 +18,73 @@
     
     package org.apache.flink.api.java.io;
     
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.common.io.FileOutputFormat;
    +import org.apache.flink.core.fs.Path;
    +
     import java.io.IOException;
     import java.io.Serializable;
     import java.nio.charset.Charset;
     import java.nio.charset.IllegalCharsetNameException;
     import java.nio.charset.UnsupportedCharsetException;
     
    -import org.apache.flink.annotation.PublicEvolving;
    -import org.apache.flink.api.common.io.FileOutputFormat;
    -import org.apache.flink.core.fs.Path;
    -
    +/**
    + * {@link FileOutputFormat} that stores values by calling {@link Object#toString()} method.
    + * @param <T> type of elements
    + */
     @PublicEvolving
     public class TextOutputFormat<T> extends FileOutputFormat<T> {
     
     	private static final long serialVersionUID = 1L;
    -	
    +
     	private static final int NEWLINE = '\n';
     
     	private String charsetName;
    -	
    +
     	private transient Charset charset;
     
     	// --------------------------------------------------------------------------------------------
     
    -	public static interface TextFormatter<IN> extends Serializable {
    -		public String format(IN value);
    +
    +	/**
    +	 * Formatter that transforms values into its {@link String} representations.
    --- End diff --
    
    into its -> into their


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message