flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #4192: [FLINK-6964] [checkpoint] Fix externalized increme...
Date Wed, 12 Jul 2017 08:57:46 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4192#discussion_r126899001
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreTest.java
---
    @@ -160,9 +162,12 @@ public Void answer(InvocationOnMock invocation) throws Throwable
{
     			stateStorage,
     			Executors.directExecutor());
     
    -		SharedStateRegistry sharedStateRegistry = new SharedStateRegistry();
    +		SharedStateRegistry sharedStateRegistry = spy(new SharedStateRegistry());
     		zooKeeperCompletedCheckpointStore.recover(sharedStateRegistry);
     
    +		verify(retrievableStateHandle1.retrieveState(), times(1)).registerSharedStatesAfterRestored(sharedStateRegistry);
    --- End diff --
    
    Ok, then we have to do that before we can merge this with confidence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message