flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink issue #3943: [FLINK-6617][table] Improve JAVA and SCALA logical plans ...
Date Tue, 11 Jul 2017 13:23:32 GMT
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/3943
  
    @wuchong @sunjincheng121 @fhueske 
    
    I tried to simplify the package structure a little bit. I based my changes on top of this
PRs commit.
    
    My goals:
    
    - splitting a class like (`ExpressionReductionTest`) in 6 classes is not very helpful
    - tests are named like the operator or feature that they are testing e.g. `Calc`, `Distinct`
etc. (we don't need `CastingITCase`, `CalcITCase`, `ScalarFunctionITCase`; `CalcITCase` covers
everything)
    - all tests have the same name everywhere (`OverWindowTest`, `OverWindowValidationTest`,
`OverWindowITCase`, `OverWindowStringExpressionTest`)
    - no packages with one class
    - `org.apache.flink.table.api` contains all tests that test the translation from batch/stream/table/sql
APIs
    - `org.apache.flink.table.plan` contains all tests that modify the plan
    - `org.apache.flink.table.runtime` contains all ITCases and runtime relevant tests
    - all other package contain unit tests for the classes of the same package
    
    You can find my branch here: https://github.com/apache/flink/compare/master...twalthr:FLINK-6617


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message