flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4279: [FLINK-7126] [table] Support Distinct for Stream S...
Date Tue, 11 Jul 2017 13:20:50 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4279#discussion_r126685098
  
    --- Diff: docs/dev/table/sql.md ---
    @@ -284,12 +284,14 @@ FROM Orders
         <tr>
           <td>
             <strong>Distinct</strong><br>
    -        <span class="label label-primary">Batch</span>
    +        <span class="label label-primary">Batch</span> <span class="label
label-primary">Streaming</span> <br>
    +        <span class="label label-info">Result Updating</span>
           </td>
           <td>
     {% highlight sql %}
     SELECT DISTINCT users FROM Orders
     {% endhighlight %}
    +       <p><b>Note:</b> DISTINCT on a streaming table produces an updating
result. And for streaming queries the required state to compute the query result might grow
infinitely depending on the number of distinct fields. Please provide a query configuration
with valid retention interval to prevent excessive state size. See <a href="streaming.html">Streaming
Concepts</a> for details.</p>
    --- End diff --
    
    I think we do not need this first sentence (should be covert by the "Result Updating"
tag). 
    -> `And for streaming queries the required ...` -> `For streaming queries the required
...`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message