flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjureel <...@git.apache.org>
Subject [GitHub] flink pull request #4278: [FLINK-7099] Replace usages of deprecated JOB_MANA...
Date Mon, 10 Jul 2017 06:40:39 GMT
Github user zjureel commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java
    @@ -91,12 +91,11 @@ public static void submitTopology(final String name, final Map stormConf,
     		final Configuration flinkConfig = GlobalConfiguration.loadConfiguration();
     		if (!stormConf.containsKey(Config.NIMBUS_HOST)) {
    -					flinkConfig.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, "localhost"));
    +					flinkConfig.getString(JobManagerOptions.ADDRESS, "localhost"));
     		if (!stormConf.containsKey(Config.NIMBUS_THRIFT_PORT)) {
    -					new Integer(flinkConfig.getInteger(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY,
    --- End diff --
    @zentol Thank you for your review. The default value of `JobManagerOptions.PORT` is 6123,
I think maybe we use `flinkConfig.getInteger(JobManagerOptions.PORT)` here instead of `flinkConfig.getInteger(JobManagerOptions.PORT,
6123)` is better. What do you think? Thanks :)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message