flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4278: [FLINK-7099] Replace usages of deprecated JOB_MANA...
Date Fri, 07 Jul 2017 08:29:38 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
    @@ -185,8 +185,8 @@ public static WebMonitor startWebMonitorIfConfigured(
     		// this ensures correct values are present in the web frontend
     		final Address address = AkkaUtils.getAddress(actorSystem);
    -		config.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, address.host().get());
    -		config.setString(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY, address.port().get().toString());
    +		config.setString(JobManagerOptions.ADDRESS, address.host().get());
    +		config.setInteger(JobManagerOptions.PORT, Integer.parseInt(address.port().get().toString()));
    --- End diff --
    skip conversion using `toString()`, then we don't need to parse it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message