flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4270: [FLINK-7110] [client] Add per-job cluster deployme...
Date Thu, 06 Jul 2017 15:40:55 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java
    @@ -44,5 +45,12 @@
     	 * @return Client for the cluster
     	 * @throws UnsupportedOperationException if this cluster descriptor doesn't support
the operation
    -	ClientType deploy() throws UnsupportedOperationException;
    +	ClientType deploySession() throws UnsupportedOperationException;
    +	/**
    +	 * Deploys a per-job cluster with the given job on the cluster.
    +	 *
    +	 * @return Cluster client to talk to the Flink cluster
    +	 */
    +	ClientType deployJob(final JobGraph jobGraph);
    --- End diff --
    I actually think that we should replace the unchecked exception by a checked exception.
I will introduce one for this method. Changing the exception of `deploySession` is a follow
up, then.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message