flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #4206: [FLINK-6996] FlinkKafkaProducer010 doesn't guarant...
Date Tue, 04 Jul 2017 08:07:00 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4206#discussion_r125411974
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironment.java
---
    @@ -80,6 +82,12 @@ public void createTestTopic(String topic, int numberOfPartitions, int
replicatio
     
     	public abstract <T> FlinkKafkaConsumerBase<T> getConsumer(List<String>
topics, KeyedDeserializationSchema<T> readSchema, Properties props);
     
    +	public abstract <K, V> Collection<ConsumerRecord<K, V>> getAllRecordsFromTopic(
    +		Properties properties,
    +		String topic,
    +		int partition,
    +		long timeout);
    --- End diff --
    
    nit: the indentation pattern is inconsistent with the other abstract method declarations
here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message