flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DmytroShkvyra <...@git.apache.org>
Subject [GitHub] flink pull request #4001: [FLINK-5476] Fail fast if trying to submit a job t...
Date Mon, 03 Jul 2017 08:52:36 GMT
Github user DmytroShkvyra commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4001#discussion_r125238449
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/StandaloneClusterClient.java
---
    @@ -70,6 +76,8 @@ public GetClusterStatusResponse getClusterStatus() {
     			} else {
     				throw new RuntimeException("Received the wrong reply " + result + " from cluster.");
     			}
    +		} catch (FlinkRuntimeException | FlinkException e) {
    --- End diff --
    
    Hi! @tillrohrmann , We can get there even FlinkException,. I just tried use more common
approach for processing exception while getting Cluster status and prevent unpredictable test
failure.  Maybe it would better throw there only FlinkRuntimeException in all cases. It makes
job fail without any timeout.  What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message