Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7B948200C92 for ; Mon, 12 Jun 2017 18:35:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7A455160BD9; Mon, 12 Jun 2017 16:35:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C1429160BCF for ; Mon, 12 Jun 2017 18:35:02 +0200 (CEST) Received: (qmail 55432 invoked by uid 500); 12 Jun 2017 16:35:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 55423 invoked by uid 99); 12 Jun 2017 16:35:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Jun 2017 16:35:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9A770C2566 for ; Mon, 12 Jun 2017 16:35:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.011 X-Spam-Level: X-Spam-Status: No, score=-100.011 tagged_above=-999 required=6.31 tests=[SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4xhwAI2ZZEwp for ; Mon, 12 Jun 2017 16:35:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E227C5FB32 for ; Mon, 12 Jun 2017 16:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 71200E07D6 for ; Mon, 12 Jun 2017 16:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1480621D8F for ; Mon, 12 Jun 2017 16:35:00 +0000 (UTC) Date: Mon, 12 Jun 2017 16:35:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-6901) Flip checkstyle configuration files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 12 Jun 2017 16:35:03 -0000 [ https://issues.apache.org/jira/browse/FLINK-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046746#comment-16046746 ] ASF GitHub Bot commented on FLINK-6901: --------------------------------------- Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4112 @zentol did you mean to include `[FLINK-6902] Activate strict checkstyle for flink-streaming-scala` as the first commit? > Flip checkstyle configuration files > ----------------------------------- > > Key: FLINK-6901 > URL: https://issues.apache.org/jira/browse/FLINK-6901 > Project: Flink > Issue Type: Improvement > Components: Checkstyle > Affects Versions: 1.4.0 > Reporter: Chesnay Schepler > Assignee: Chesnay Schepler > > We currently have 2 checkstyle files, {{checkstyle.xml}} as the basic version, and {{strict-checkstyle.xml}} as a heavily expanded version that is applied to most existing modules (see FLINK-6698). > [~greghogan] suggested to flip the checkstyle while reviewing this PR https://github.com/apache/flink/pull/4086, given that the strict checkstyle is supposed to subsume the existing checkstyle in the long-term. -- This message was sent by Atlassian JIRA (v6.4.14#64029)