Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 14 Jun 2017 08:37:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13076828.1496405737000.15228.1497429420161@Atlassian.JIRA>
In-Reply-To: <JIRA.13076828.1496405737000@Atlassian.JIRA>
References: <JIRA.13076828.1496405737000@Atlassian.JIRA> <JIRA.13076828.1496405737408@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-6817) Fix NPE when preceding is not set
 in OVER window
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 14 Jun 2017 08:37:05 -0000


    [ https://issues.apache.org/jira/browse/FLINK-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048869#comment-16048869 ] 

ASF GitHub Bot commented on FLINK-6817:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4104
  
    This should be the same code as #4055 because the windows should not have changed on the `master` branch since the release right?
    If that's the case, I'm +1 for merging as well.
    
    btw. we usually do not open separate PRs for different branches (unless there is backporting required due to changes on `master` branch). Instead, you can cherrypick the commit from the `master` branch into the `release-1.3` branch, run the tests (on Travis), and commit to the release branch.


> Fix NPE when preceding is not set in OVER window
> ------------------------------------------------
>
>                 Key: FLINK-6817
>                 URL: https://issues.apache.org/jira/browse/FLINK-6817
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> When preceding is not set in over window , a NPE will be thrown:
> {code}
> val result = table
>       .window(Over orderBy 'rowtime as 'w)
>       .select('c, 'a.count over 'w)
> {code}
> {code}
> java.lang.NullPointerException
> 	at org.apache.flink.table.api.OverWindowWithOrderBy.as(windows.scala:97)
> {code}
> Preceding must be set in OVER window, so should throw a more explicit exception not a NPE


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)