Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7F308200CAE for ; Wed, 7 Jun 2017 03:09:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7E33C160BD3; Wed, 7 Jun 2017 01:09:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C539A160BC6 for ; Wed, 7 Jun 2017 03:09:21 +0200 (CEST) Received: (qmail 26731 invoked by uid 500); 7 Jun 2017 01:09:20 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 26722 invoked by uid 99); 7 Jun 2017 01:09:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2017 01:09:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D32DB1AFE22 for ; Wed, 7 Jun 2017 01:09:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id uJhdX2mTr5QD for ; Wed, 7 Jun 2017 01:09:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D565F5F613 for ; Wed, 7 Jun 2017 01:09:18 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5470AE00A0 for ; Wed, 7 Jun 2017 01:09:18 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1194C21E0A for ; Wed, 7 Jun 2017 01:09:18 +0000 (UTC) Date: Wed, 7 Jun 2017 01:09:18 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (FLINK-6422) Unreachable code in FileInputFormat#createInputSplits MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 07 Jun 2017 01:09:22 -0000 [ https://issues.apache.org/jira/browse/FLINK-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6422: -------------------------- Description: Here is related code: {code} if (minNumSplits < 1) { throw new IllegalArgumentException("Number of input splits has to be at least 1."); } ... final long maxSplitSize = (minNumSplits < 1) ? Long.MAX_VALUE : (totalLength / minNumSplits + (totalLength % minNumSplits == 0 ? 0 : 1)); {code} minNumSplits wouldn't be less than 1 getting to the assignment of maxSplitSize. was: Here is related code: {code} if (minNumSplits < 1) { throw new IllegalArgumentException("Number of input splits has to be at least 1."); } ... final long maxSplitSize = (minNumSplits < 1) ? Long.MAX_VALUE : (totalLength / minNumSplits + (totalLength % minNumSplits == 0 ? 0 : 1)); {code} minNumSplits wouldn't be less than 1 getting to the assignment of maxSplitSize. > Unreachable code in FileInputFormat#createInputSplits > ----------------------------------------------------- > > Key: FLINK-6422 > URL: https://issues.apache.org/jira/browse/FLINK-6422 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats > Reporter: Ted Yu > Priority: Minor > > Here is related code: > {code} > if (minNumSplits < 1) { > throw new IllegalArgumentException("Number of input splits has to be at least 1."); > } > ... > final long maxSplitSize = (minNumSplits < 1) ? Long.MAX_VALUE : (totalLength / minNumSplits + > (totalLength % minNumSplits == 0 ? 0 : 1)); > {code} > minNumSplits wouldn't be less than 1 getting to the assignment of maxSplitSize. -- This message was sent by Atlassian JIRA (v6.3.15#6346)