Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 29 Jun 2017 07:35:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13049677.1489081330000.132356.1498721700920@Atlassian.JIRA>
In-Reply-To: <JIRA.13049677.1489081330000@Atlassian.JIRA>
References: <JIRA.13049677.1489081330000@Atlassian.JIRA> <JIRA.13049677.1489081330145@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-6008) collection of BlobServer
 improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 29 Jun 2017 07:35:09 -0000


    [ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067919#comment-16067919 ] 

ASF GitHub Bot commented on FLINK-6008:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4146#discussion_r124727900
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java ---
    @@ -509,21 +509,7 @@ private void delete(InputStream inputStream, OutputStream outputStream, byte[] b
     
     			if (type == CONTENT_ADDRESSABLE) {
     				BlobKey key = BlobKey.readFromInputStream(inputStream);
    -				File blobFile = blobServer.getStorageLocation(key);
    -
    -				writeLock.lock();
    -
    -				try {
    -					// we should make the local and remote file deletion atomic, otherwise we might risk not
    -					// removing the remote file in case of a concurrent put operation
    -					if (blobFile.exists() && !blobFile.delete()) {
    -						throw new IOException("Cannot delete BLOB file " + blobFile.getAbsolutePath());
    --- End diff --
    
    Ok, sorry, I didn't find it first time I was looking for it.


> collection of BlobServer improvements
> -------------------------------------
>
>                 Key: FLINK-6008
>                 URL: https://issues.apache.org/jira/browse/FLINK-6008
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.3.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> The following things should be improved around the BlobServer/BlobCache:
> * update config uptions with non-deprecated ones, e.g. {{high-availability.cluster-id}} and {{high-availability.storageDir}}
> * promote {{BlobStore#deleteAll(JobID)}} to the {{BlobService}}
> * extend the {{BlobService}} to work with {{NAME_ADDRESSABLE}} blobs (prepares FLINK-4399]
> * remove {{NAME_ADDRESSABLE}} blobs after job/task termination
> * do not fail the {{BlobServer}} when a delete operation fails
> * code style, like using {{Preconditions.checkArgument}}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)