Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: sunjincheng121 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4138-flink@git.apache.org>
In-Reply-To: <git-pr-4138-flink@git.apache.org>
Subject: [GitHub] flink pull request #4138: [FLINK-6925][table]Add CONCAT/CONCAT_WS supported ...
Content-Type: text/plain
Message-Id: <20170628162136.DEFEBDFC24@git1-us-west.apache.org>
Date: Wed, 28 Jun 2017 16:21:36 +0000 (UTC)
archived-at: Wed, 28 Jun 2017 16:21:41 -0000

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4138#discussion_r124588196
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala ---
    @@ -0,0 +1,87 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.runtime.functions
    +
    +import scala.annotation.varargs
    +import java.math.{BigDecimal => JBigDecimal}
    +import java.lang.{StringBuffer => JStringBuffer}
    +
    +/**
    +  * Built-in scalar runtime functions.
    +  */
    +class ScalarFunctions {}
    +
    +object ScalarFunctions {
    +
    +  def power(a: Double, b: JBigDecimal): Double = {
    +    Math.pow(a, b.doubleValue())
    +  }
    +
    +  /**
    +    * Returns the string that results from concatenating the arguments.
    +    * Returns NULL if any argument is NULL.
    +    */
    +  @varargs
    +  def concat(args: String*): String = {
    +    val sb = new JStringBuffer
    --- End diff --
    
    Yes, we do not need `supplemented ` the `append` method. Good catch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---