Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: dawidwys <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4195-flink@git.apache.org>
In-Reply-To: <git-pr-4195-flink@git.apache.org>
Subject: [GitHub] flink pull request #4195: [FLINK-7008] [cep] Update NFA state only when the ...
Content-Type: text/plain
Message-Id: <20170628110236.0CBADDFAF5@git1-us-west.apache.org>
Date: Wed, 28 Jun 2017 11:02:36 +0000 (UTC)
archived-at: Wed, 28 Jun 2017 11:02:40 -0000

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4195#discussion_r124511647
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -237,8 +254,15 @@ public boolean isEmpty() {
     						computationState.getCounter());
     
     				newComputationStates = Collections.emptyList();
    +				nfaChanged = true;
    --- End diff --
    
    Yes, you are right! I think then a test for that case would also be nice ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---