Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tzulitai <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4206-flink@git.apache.org>
In-Reply-To: <git-pr-4206-flink@git.apache.org>
Subject: [GitHub] flink pull request #4206: [FLINK-6996] FlinkKafkaProducer010 doesn't guarant...
Content-Type: text/plain
Message-Id: <20170628072745.81940DFA3E@git1-us-west.apache.org>
Date: Wed, 28 Jun 2017 07:27:45 +0000 (UTC)
archived-at: Wed, 28 Jun 2017 07:27:51 -0000

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4206#discussion_r124467541
  
    --- Diff: flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka08ProducerITCase.java ---
    @@ -18,17 +18,19 @@
     
     package org.apache.flink.streaming.connectors.kafka;
     
    -import org.junit.Test;
    -
     /**
      * IT cases for the {@link FlinkKafkaProducer08}.
      */
     @SuppressWarnings("serial")
     public class Kafka08ProducerITCase extends KafkaProducerTestBase {
     
    -	@Test
    -	public void testCustomPartitioning() {
    -		runCustomPartitioningTest();
    +	@Override
    +	public void testOneToOneAtLeastOnceRegularSink() throws Exception {
    +		// TODO: enable this for Kafka 0.8 - now it hangs indefinitely
     	}
     
    +	@Override
    +	public void testOneToOneAtLeastOnceCustomOperator() throws Exception {
    +		// Disable this test since FlinkKafka08Producer doesn't support writing timestamps
    --- End diff --
    
    I would perhaps rephrase this comment a bit:
    it's disabled because FlinkKafka08Producer doesn't run in the custom operator mode (to be coherent with the test case name)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---