Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F0D4E200CB4 for ; Tue, 27 Jun 2017 14:11:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EF5AB160BE9; Tue, 27 Jun 2017 12:11:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 40CF1160BDC for ; Tue, 27 Jun 2017 14:11:49 +0200 (CEST) Received: (qmail 12913 invoked by uid 500); 27 Jun 2017 12:11:48 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 12904 invoked by uid 99); 27 Jun 2017 12:11:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 12:11:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1C49EC00A9 for ; Tue, 27 Jun 2017 12:11:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.02 X-Spam-Level: X-Spam-Status: No, score=-4.02 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id zKIILsmIVxfh for ; Tue, 27 Jun 2017 12:11:47 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id B9EB65F60D for ; Tue, 27 Jun 2017 12:11:46 +0000 (UTC) Received: (qmail 12879 invoked by uid 99); 27 Jun 2017 12:11:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 12:11:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 65A0FDFAB0; Tue, 27 Jun 2017 12:11:45 +0000 (UTC) From: wuchong To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #4186: [FLINK-7005] [table] Optimization steps are missing for n... Content-Type: text/plain Message-Id: <20170627121145.65A0FDFAB0@git1-us-west.apache.org> Date: Tue, 27 Jun 2017 12:11:45 +0000 (UTC) archived-at: Tue, 27 Jun 2017 12:11:50 -0000 Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4186 Looks good from my side. I think it's fine to make the CONV_RULES non-optional for now. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---