Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4168-flink@git.apache.org>
In-Reply-To: <git-pr-4168-flink@git.apache.org>
Subject: [GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...
Content-Type: text/plain
Message-Id: <20170627092402.0C2C3DFB0D@git1-us-west.apache.org>
Date: Tue, 27 Jun 2017 09:24:02 +0000 (UTC)
archived-at: Tue, 27 Jun 2017 09:24:06 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4168#discussion_r124223192
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java ---
    @@ -461,8 +463,9 @@ public LocatableInputSplitAssigner getInputSplitAssigner(FileInputSplit[] splits
     		
     		// take the desired number of splits into account
     		minNumSplits = Math.max(minNumSplits, this.numSplits);
    -		
    -		final Path path = this.filePath;
    +
    +		final Path path = new Path(URLDecoder.decode(this.filePath.toString(), Charset.defaultCharset().name()));
    --- End diff --
    
    That#s a problem of URI, not of the path class. URI#toString escapes certain characters (like spaces) but they aren't escaped internally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---