Return-Path: <issues-return-117912-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 6BA01200CB0
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 23 Jun 2017 12:09:05 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 69F01160BF2; Fri, 23 Jun 2017 10:09:05 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id B1B92160BD4
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 23 Jun 2017 12:09:04 +0200 (CEST)
Received: (qmail 71925 invoked by uid 500); 23 Jun 2017 10:09:03 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 71916 invoked by uid 99); 23 Jun 2017 10:09:03 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jun 2017 10:09:03 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 806E81A020C
	for <issues@flink.apache.org>; Fri, 23 Jun 2017 10:09:03 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id qXRldkybtoZz for <issues@flink.apache.org>;
	Fri, 23 Jun 2017 10:09:01 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 067785FC12
	for <issues@flink.incubator.apache.org>; Fri, 23 Jun 2017 10:09:00 +0000 (UTC)
Received: (qmail 71388 invoked by uid 99); 23 Jun 2017 10:08:58 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jun 2017 10:08:58 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 178CDE03B3; Fri, 23 Jun 2017 10:08:57 +0000 (UTC)
From: kl0u <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4143-flink@git.apache.org>
In-Reply-To: <git-pr-4143-flink@git.apache.org>
Subject: [GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...
Content-Type: text/plain
Message-Id: <20170623100857.178CDE03B3@git1-us-west.apache.org>
Date: Fri, 23 Jun 2017 10:08:57 +0000 (UTC)
archived-at: Fri, 23 Jun 2017 10:09:05 -0000

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4143#discussion_r123715389
  
    --- Diff: docs/dev/libs/cep.md ---
    @@ -334,6 +334,20 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or condition
     </div>
     </div>
     
    +
    +**Stop condition:** In case of kleene operators (`oneOrMore()` and `oneOrMore().optional()`) you can
    +also specify a stop condition, e.g. accept events with value larger than 5 until the sum of values is smaller than 50.
    --- End diff --
    
    In general, I would not use the "kleene" term, as we do not use it throughout the rest of the docs.
    You can say sth like "looping" or simply oneOrMore.
    In addition, it would also be more consistent to not use "operator" but "pattern". In the docs we have "pattern sequences" composed of "patterns" so we should stick to that.
    
    So "Kleene Operator" -> "looping pattern" or "oneOrMore pattern"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---