Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4075-flink@git.apache.org>
In-Reply-To: <git-pr-4075-flink@git.apache.org>
Subject: [GitHub] flink pull request #4075: [FLINK-6494] Migrate ResourceManager/Yarn/Mesos co...
Content-Type: text/plain
Message-Id: <20170620154458.DA1A1E0A38@git1-us-west.apache.org>
Date: Tue, 20 Jun 2017 15:44:58 +0000 (UTC)
archived-at: Tue, 20 Jun 2017 15:45:04 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4075#discussion_r123014657
  
    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosConfigOptions.java ---
    @@ -0,0 +1,110 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.mesos.configuration;
    +
    +import org.apache.flink.configuration.ConfigOption;
    +
    +import static org.apache.flink.configuration.ConfigOptions.key;
    +
    +/**
    + * This class holds configuration constants used by Flink's MESOS runners.
    + *
    + * <p>These options are not expected to be ever configured by users explicitly.
    + */
    +public class MesosConfigOptions {
    +
    +	/**
    +	 * The initial number of Mesos tasks to allocate.
    +	 */
    +	public static final ConfigOption<Integer> MESOS_INITIAL_TASKS =
    +		key("mesos.initial-tasks")
    +		.defaultValue(0);
    +
    +	/**
    +	 * The maximum number of failed Mesos tasks before entirely stopping
    +	 * the Mesos session / job on Mesos.
    +	 *
    +	 * <p>By default, we take the number of of initially requested tasks.
    +	 */
    +	public static final ConfigOption<String> MESOS_MAX_FAILED_TASKS =
    +		key("mesos.maximum-failed-tasks")
    +		.noDefaultValue();
    +
    +	/**
    +	 * The Mesos master URL.
    +	 *
    +	 * <p>The value should be in one of the following forms:
    +	 * <pre>
    +	 * {@code
    +	 *     host:port
    +	 *     zk://host1:port1,host2:port2,.../path
    +	 *     zk://username:password@host1:port1,host2:port2,.../path
    +	 *     file:///path/to/file (where file contains one of the above)
    +	 * }
    +	 * </pre>
    +	 *
    +	 */
    +	public static final ConfigOption<String> MESOS_MASTER_URL =
    +		key("mesos.master").noDefaultValue();
    +
    +	/**
    +	 * The failover timeout for the Mesos scheduler, after which running tasks are automatically shut down.
    +	 *
    +	 * <p>The default value is 600 (seconds).
    --- End diff --
    
    dont need this comment anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---