Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: lmalds <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4135-flink@git.apache.org>
In-Reply-To: <git-pr-4135-flink@git.apache.org>
Subject: [GitHub] flink pull request #4135: Flink 6602 -- bug fix
Content-Type: text/plain
Message-Id: <20170616201607.5A2EFE00EF@git1-us-west.apache.org>
Date: Fri, 16 Jun 2017 20:16:06 +0000 (UTC)
archived-at: Fri, 16 Jun 2017 20:16:12 -0000

Github user lmalds commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4135#discussion_r122525124
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/StreamTableSourceTable.scala ---
    @@ -39,6 +39,9 @@ class StreamTableSourceTable[T](
         val fieldCnt = fieldNames.length
     
         val rowtime = tableSource match {
    +      case nullTimeSource : DefinedRowtimeAttribute if nullTimeSource.getRowtimeAttribute == null => None
    +      case emptyStringTimeSource : DefinedRowtimeAttribute if emptyStringTimeSource.getRowtimeAttribute.trim.equals("")  =>
    +        throw TableException("The name of the rowtime attribute must not be empty.")
           case timeSource: DefinedRowtimeAttribute if timeSource.getRowtimeAttribute != null =>
    --- End diff --
    
    You mean there is no need to add the last if condition (should change "case timeSource: DefinedRowtimeAttribute if timeSource.getRowtimeAttribute != null =>" to "case timeSource: DefinedRowtimeAttribute =>")? Is it right?
    
    Thanks for your patient guidance.
    
    I commited again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---