Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3838-flink@git.apache.org>
In-Reply-To: <git-pr-3838-flink@git.apache.org>
Subject: [GitHub] flink pull request #3838: [FLINK-5886] Python API for streaming applications
Content-Type: text/plain
Message-Id: <20170614094808.4854AF35D6@git1-us-west.apache.org>
Date: Wed, 14 Jun 2017 09:48:08 +0000 (UTC)
archived-at: Wed, 14 Jun 2017 09:48:14 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3838#discussion_r121900972
  
    --- Diff: flink-libraries/flink-streaming-python/src/main/java/org/apache/flink/streaming/python/util/serialization/PythonSerializationSchema.java ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.python.util.serialization;
    +
    +import java.io.IOException;
    +
    +import org.apache.flink.streaming.util.serialization.SerializationSchema;
    +import org.python.core.PyObject;
    +
    +/**
    + * A Python serialization schema, which implements {@link SerializationSchema}. It converts
    + * a {@code PyObject} into its serialized form.
    + */
    +public class PythonSerializationSchema implements SerializationSchema<PyObject> {
    +	private static final long serialVersionUID = -9170596504893036458L;
    +
    +	private final byte[] serSchema;
    +	private transient SerializationSchema<PyObject> schema;
    +
    +	public PythonSerializationSchema(SerializationSchema<PyObject> schema) throws IOException {
    +		this.serSchema = SerializationUtils.serializeObject(schema);
    +	}
    +
    +	@Override
    +	@SuppressWarnings("unchecked")
    +	public byte[] serialize(PyObject element) {
    +		if (this.schema == null) {
    +			try {
    +				this.schema = (SerializationSchema<PyObject>)SerializationUtils.deserializeObject(this.serSchema);
    +			} catch (IOException e) {
    +				e.printStackTrace();
    --- End diff --
    
    we should fail right here, as otherwise we get an NPE later on anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---