Return-Path: <issues-return-115537-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id BB118200C8C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue,  6 Jun 2017 17:55:47 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id B9A82160BEC; Tue,  6 Jun 2017 15:55:47 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 14A60160BC6
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  6 Jun 2017 17:55:46 +0200 (CEST)
Received: (qmail 18013 invoked by uid 500); 6 Jun 2017 15:55:46 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 18004 invoked by uid 99); 6 Jun 2017 15:55:46 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 15:55:46 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D3009C349B
	for <issues@flink.apache.org>; Tue,  6 Jun 2017 15:55:45 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.029
X-Spam-Level: 
X-Spam-Status: No, score=-4.029 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id f34iHfRwHQPg for <issues@flink.apache.org>;
	Tue,  6 Jun 2017 15:55:45 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 403CB5FC57
	for <issues@flink.incubator.apache.org>; Tue,  6 Jun 2017 15:55:44 +0000 (UTC)
Received: (qmail 17481 invoked by uid 99); 6 Jun 2017 15:55:43 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 15:55:43 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 445FAE04AA; Tue,  6 Jun 2017 15:55:43 +0000 (UTC)
From: twalthr <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4039-flink@git.apache.org>
In-Reply-To: <git-pr-4039-flink@git.apache.org>
Subject: [GitHub] flink pull request #4039: [FLINK-6783] Changed passing index of type argumen...
Content-Type: text/plain
Message-Id: <20170606155543.445FAE04AA@git1-us-west.apache.org>
Date: Tue,  6 Jun 2017 15:55:43 +0000 (UTC)
archived-at: Tue, 06 Jun 2017 15:55:47 -0000

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4039#discussion_r120397022
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java ---
    @@ -231,14 +231,18 @@ protected WithWindow(DataStream<T1> input1,
     		public <T> DataStream<T> apply(CoGroupFunction<T1, T2, T> function) {
     
     			TypeInformation<T> resultType = TypeExtractor.getBinaryOperatorReturnType(
    -					function,
    -					CoGroupFunction.class,
    -					true,
    -					true,
    -					input1.getType(),
    -					input2.getType(),
    -					"CoGroup",
    -					false);
    +				function,
    --- End diff --
    
    We could use `TypeExtractor#getCoGroupReturnTypes()` and save some duplicate code, but I'm also fine with this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---