flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4142: [FLINK-6948] Harden EnumValueSerializer to detect ...
Date Mon, 19 Jun 2017 10:53:24 GMT
GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4142

    [FLINK-6948] Harden EnumValueSerializer to detect changed enum indices

    This PR changes the seriailization format of the ScalaEnumSerializerConfigSnapshot to
also include the
    ordinal value of an enum value when being deserialized. This allows to detect if the ordinal
values
    have been changed and, thus, if migration is required.
    
    IMPORTANT: This PR changes the serialization format of ScalaEnumSerializerConfigSnapshot.
    
    cc @tzulitai 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink hardenEnumValueSerializerTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4142
    
----
commit 80b2d61b58be06f9e3f40b35f0b215421ad86890
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-06-13T21:26:10Z

    [FLINK-6836] [tests] Fix YARNSessionCapacitySchedulerITCase to work with Hadoop 2.6.5,
2.7.3 and 2.8.0
    
    Due to MNG-5899, maven cannot resolve dependency reduced poms in a multi project build.
Therefore,
    flink-yarn-tests pulls in a wrong version of org.apache.httpcomponents.httpclient which
does not work
    with Hadoop's ServletUtils together. As a solution we have to move the dependency management
for the
    httpclient and httpcore version into the parent pom.xml.
    
    Another problem is the version of these libraries which has been recently bumped. In 4.4,
httpclient
    changed its behaviour such that URLEncodedUtils#parse(String, Charset) now throws a NPE
if the first
    parameter is null. In 4.2.6, an empty list was returned instead. Due to this incompatibility,
we reverted
    the change and set the version to its previous value.
    
    Bump httpclient to 4.5.3 and httpcore to 4.4.6
    
    This closes #4120.

commit 7c7fe493f2dd766a8ddf3de240f9447f857b423a
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-06-14T14:53:49Z

    [FLINK-6921] [serializer] Allow EnumValueSerializer to deal with appended enum values
    
    The problem was that we don't check the bounds of the array with the enum names contained
    in the ScalaEnumSerializerConfigSnapshot.
    
    This PR also adds an Enumeration upgrade test which makes sure that appended fields are
    supported without migration. Moreover, it checks that a field removal and an order change
    leads to a required migration.
    
    This closes #4126.

commit 9576530a0c5c3fe866bf87f126b29eb5acb56ba2
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-06-19T10:49:05Z

    [FLINK-6948] Harden EnumValueSerializer to detect changed enum indices
    
    This PR changes the seriailization format of the ScalaEnumSerializerConfigSnapshot to
also include the
    ordinal value of an enum value when being deserialized. This allows to detect if the ordinal
values
    have been changed and, thus, if migration is required.
    
    IMPORTANT: This PR changes the serialization format of ScalaEnumSerializerConfigSnapshot.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message