flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.
Date Fri, 30 Jun 2017 10:06:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069827#comment-16069827
] 

ASF GitHub Bot commented on FLINK-7044:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4225#discussion_r125006417
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/VoidNamespaceTypeInfo.java
---
    @@ -0,0 +1,102 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.state;
    +
    +import org.apache.flink.annotation.Public;
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.common.ExecutionConfig;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +
    +/**
    + * {@link TypeInformation} for {@link VoidNamespace}.
    + */
    +@Public
    +public class VoidNamespaceTypeInfo extends TypeInformation<VoidNamespace> {
    +
    +	private static final long serialVersionUID = 5453679706408610586L;
    +
    +	public static final VoidNamespaceTypeInfo INSTANCE = new VoidNamespaceTypeInfo();
    +
    +	@Override
    +	@PublicEvolving
    --- End diff --
    
    I also had it as you describe but changed it because I checked the other classes. 
    I think the intention is to tell the user that the `TypeInformation` will always be there
(thus `@Public`) but the implementation may change (`@PublicEvolving`). 
    
    For uniformity, I would suggest to keep it as the others and probably create another issue
that changes all the related annotations. I think this will lead to a more consistent approach
and whoever set these annotations in the first place will have the opportunity to say if this
change seems ok. 


> Add methods to the client API that take the stateDescriptor.
> ------------------------------------------------------------
>
>                 Key: FLINK-7044
>                 URL: https://issues.apache.org/jira/browse/FLINK-7044
>             Project: Flink
>          Issue Type: Improvement
>          Components: Queryable State
>    Affects Versions: 1.3.0, 1.3.1
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message