flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7014) Expose isDeterministic interface to ScalarFunction and TableFunction
Date Wed, 28 Jun 2017 10:24:03 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066288#comment-16066288
] 

ASF GitHub Bot commented on FLINK-7014:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4200#discussion_r124504426
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
    @@ -458,4 +459,52 @@ class ExpressionReductionTest extends TableTestBase {
         util.verifySql(sqlQuery, expected)
       }
     
    +  // todo this NPE is caused by Calcite, it shall pass when [CALCITE-1860] is fixed
    +  @Ignore
    +  @Test(expected = classOf[NullPointerException])
    --- End diff --
    
    What is the expected result of the test given that CALCITE-1860 is fixed?
    Since the test is ignored, we should implement the test such that is validates the expected
result. 


> Expose isDeterministic interface to ScalarFunction and TableFunction
> --------------------------------------------------------------------
>
>                 Key: FLINK-7014
>                 URL: https://issues.apache.org/jira/browse/FLINK-7014
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>
> Currently, the `isDeterministic` method of implementations of `SqlFuntion` are always
returning true, which cause inappropriate optimization in Calcite, such as taking user's stateful
UDF as a pure functional procedure. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message