flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7007) Add README to "flink-shaded.git" repository
Date Tue, 27 Jun 2017 17:03:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065138#comment-16065138
] 

ASF GitHub Bot commented on FLINK-7007:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink-shaded/pull/3#discussion_r124335176
  
    --- Diff: README.md ---
    @@ -0,0 +1,28 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +
    +# Apache Flink Shaded Dependencies
    +
    +This repository contains a number of shaded dependencies for the [Apache Flink](https://flink.apache.org/)
project.
    +
    +The purpose of these dependencies is to provide a single instance of a shaded dependency
in the Flink distribution, instead of each individual module shading the dependency.
    +
    +The shaded dependencies contained here do not expose any transitive dependencies. They
may or may not be self-contained.
    +
    +When using these dependencies it is recommended to work directly against the shaded namespaces.
    --- End diff --
    
    Could you add the following
    ```
    About
    
    Apache Flink is an open source project of The Apache Software Foundation (ASF).
    ``` 
    and link to the ASF?
    
    Other than that +1 to merge


> Add README to "flink-shaded.git" repository
> -------------------------------------------
>
>                 Key: FLINK-7007
>                 URL: https://issues.apache.org/jira/browse/FLINK-7007
>             Project: Flink
>          Issue Type: Sub-task
>          Components: flink-shaded.git
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>
> We should put a README file up there with a brief explanation of the purpose of the repo
+ some links to the project.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message