flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7000) Add custom configuration for StreamExecutionEnvironment#createLocalEnvironment
Date Sun, 25 Jun 2017 08:21:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062263#comment-16062263

ASF GitHub Bot commented on FLINK-7000:

Github user ch33hau commented on the issue:

    Hi @zentol , thanks for taking time for reviewing :)
    It was my original thought. 
    However turns out due to `Scala` supports `default value` in parameters, in order to achieve
same behaviour as Java, adding a new method is not working here.
     This is what currently Java has:
        1. createLocalEnvironment()
        2. createLocalEnvironment(Int)
        3. createLocalEnvironment(Int, Configuration)
    Before this PR, in Scala we have:
        createLocalEnvironment(Int = defaultValue)
    So a Scala user can access this method by `createLocalEnvironment()` or `createLocalEnvironment(someValue)`.
    If I add another method `createLocalEnvironment(Int = defaultValue, conf = defaultValue)`,
compiler will complain because at this moment `createLocalEnvironment(someValue)` is ambiguous.
    My opinion is by just adding a parameter with default value to existing method, it doesn't
change the existing way to access the method. 
    How do you think?

> Add custom configuration for StreamExecutionEnvironment#createLocalEnvironment
> ------------------------------------------------------------------------------
>                 Key: FLINK-7000
>                 URL: https://issues.apache.org/jira/browse/FLINK-7000
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Lim Chee Hau
> I was doing some local testings in {{Scala}} environment, however I found that there
is no straightforward way to add custom configuration to {{StreamExecutionEnvironment}} by
using {{createLocalEnvironment}} method. 
> This could be easily achieve in {{Java}} environment since {{StreamExecutionEnvironment}}
in {{Java}} has 
> - {{createLocalEnvironment()}}
> - {{createLocalEnvironment(Int)}}
> - {{createLocalEnvironment(Int, Configuration)}}
> Whereas Scala only has 2 out of 3 of these methods.
> Not sure if this is a missing implementation, if yes I could create a PR for this.
> Therefore the example in [Local Execution|https://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/local_execution.html]
could be making sense for Scala users as well:
> bq. The LocalEnvironment allows also to pass custom configuration values to Flink.

This message was sent by Atlassian JIRA

View raw message