flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback
Date Tue, 27 Jun 2017 14:12:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064899#comment-16064899
] 

ASF GitHub Bot commented on FLINK-6998:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4187#discussion_r124235516
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
       </tbody>
     </table>
     
    +#### Connector:
    +<table class="table table-bordered">
    +  <thead>
    +    <tr>
    +      <th class="text-left" style="width: 20%">Scope</th>
    +      <th class="text-left" style="width: 30%">Metrics</th>
    +      <th class="text-left" style="width: 50%">Description</th>
    +    </tr>
    +  </thead>
    +  <tbody>
    +    <tr>
    +      <th rowspan="1">Slot/Consumer</th>
    +      <td>kafkaCommitsSucceeded</td>
    +      <td>Kafka offset commit success count if Kafka commit is turned on.</td>
    --- End diff --
    
    I would make this statement more strict, in that the metric only exists if commit is turned
on AND checkpointing is enabled. The added metrics would not appear if only Kafka's periodic
offset committing is turned on.


> Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka
Consumer callback
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6998
>                 URL: https://issues.apache.org/jira/browse/FLINK-6998
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Zhenzhong Xu
>            Assignee: Zhenzhong Xu
>
> Propose to add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in KafkaConsumerThread
class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message