flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6989) Refactor examples with Output interface
Date Wed, 28 Jun 2017 12:03:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066385#comment-16066385
] 

ASF GitHub Bot commented on FLINK-6989:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4179#discussion_r124521762
  
    --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Parameter.java
---
    @@ -40,6 +40,15 @@
     	String getUsage();
     
     	/**
    +	 * A hidden parameter is parsed from the command-line configuration but is
    +	 * not printed in the usage string. This can be used for power-user options
    +	 * not displayed to the general user.
    --- End diff --
    
    The initial use case was for disabling object reuse which a user should not be concerned
with (all the algorithms support object reuse) or even know about but is used by the integration
tests to validate the algorithms under object reuse and for comparison benchmarking.
    
    Another example is the next PR which hides the "algorithm" parallelism which is only needed
for large executions and might be confusing with the `-p` "job" parallelism.


> Refactor examples with Output interface
> ---------------------------------------
>
>                 Key: FLINK-6989
>                 URL: https://issues.apache.org/jira/browse/FLINK-6989
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Gelly
>    Affects Versions: 1.4.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.4.0
>
>
> The current organization of the Gelly examples retains full flexibility by handling the
Graph input to the algorithm Driver and having the Driver overload interfaces for the various
output types. The outputs must be made independent in order to support Transforms which are
applied between the Driver and Output (and also between the Input and Driver).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message