flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6943) Improve exceptions within TypeExtractionUtils#getSingleAbstractMethod
Date Mon, 19 Jun 2017 09:15:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053674#comment-16053674
] 

ASF GitHub Bot commented on FLINK-6943:
---------------------------------------

GitHub user dawidwys opened a pull request:

    https://github.com/apache/flink/pull/4140

    [FLINK-6943] Improve exceptions within TypeExtractionUtils#getSingleA…

    …bstractMethod
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dawidwys/flink flink6943

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4140
    
----
commit 316afb3085486186a098b4aa9607a0b269a5312b
Author: Dawid Wysakowicz <dwysakowicz@apache.org>
Date:   2017-06-19T07:38:25Z

    [FLINK-6943] Improve exceptions within TypeExtractionUtils#getSingleAbstractMethod

----


> Improve exceptions within TypeExtractionUtils#getSingleAbstractMethod
> ---------------------------------------------------------------------
>
>                 Key: FLINK-6943
>                 URL: https://issues.apache.org/jira/browse/FLINK-6943
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>
> Exception message seems to be inexact. 
> Also if there is no SAM, sam would be null upon returning from the method.
> The suggestion from a review was to change the message and add a check (for null sam)
prior to returning.
> Another suggestion is to check if the given method is an interface, as only for interface
it is possible to pass lambda.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message