flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6938) IterativeCondition should support RichFunction interface
Date Wed, 21 Jun 2017 01:59:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056830#comment-16056830
] 

ASF GitHub Bot commented on FLINK-6938:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4145#discussion_r123138630
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -1131,6 +1152,7 @@ private void serializeStates(Set<State<T>> states, DataOutputView
out) throws IO
     					nameSerializer.serialize(transition.getTargetState().getName(), out);
     					actionSerializer.serialize(transition.getAction(), out);
     
    +					// backward compatibility
     					serializeCondition(transition.getCondition(), out);
    --- End diff --
    
    I'm not sure. Do we need to backward compatible to previous version (like 1.3.0 which
serializes conditions) ?   


> IterativeCondition should support RichFunction interface
> --------------------------------------------------------
>
>                 Key: FLINK-6938
>                 URL: https://issues.apache.org/jira/browse/FLINK-6938
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>             Fix For: 1.4.0
>
>
> In FLIP-20, we need IterativeCondition to support an {{open()}} method to compile the
generated code once. We do not want to insert a if condition  in the {{filter()}} method.
So I suggest make IterativeCondition support {{RichFunction}} interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message