flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6938) IterativeCondition should support RichFunction interface
Date Tue, 20 Jun 2017 06:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055236#comment-16055236
] 

ASF GitHub Bot commented on FLINK-6938:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/4145

    [FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state and support
RichFunction interface

    The core idea is that the `StateTransition` is unique in a NFA graph. So we store the
conditions with a map which mapping from `StateTransition` to `IterativeCondition`, so the
conditions can not serialized with NFA state. If I missed something, please point out.
    
    This PR also includes FLINK-6938: IterativeCondition supports RichFunction interface.

    
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink IterativeCondition

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4145
    
----
commit dfd00d0b442b415c43120e31e94a2d5dba5c02c2
Author: Jark Wu <wuchong.wc@alibaba-inc.com>
Date:   2017-06-20T06:02:21Z

    [FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state and support
RichFunction interface

----


> IterativeCondition should support RichFunction interface
> --------------------------------------------------------
>
>                 Key: FLINK-6938
>                 URL: https://issues.apache.org/jira/browse/FLINK-6938
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>             Fix For: 1.4.0
>
>
> In FLIP-20, we need IterativeCondition to support an {{open()}} method to compile the
generated code once. We do not want to insert a if condition  in the {{filter()}} method.
So I suggest make IterativeCondition support {{RichFunction}} interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message